Re: [RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite

2024-08-29 Thread Nicholas Pratte
Hi Alex, thanks for the review! See my comments below. > > +IP_HEADER_LEN = 20 > > +ETHER_STANDARD_FRAME = 1500 > > +ETHER_JUMBO_FRAME_MTU = 9000 > > For these constants, I am confused why one is "FRAME" and the other is > "MTU". The value of 'ETHER_STANDARD_FRAME' is 1500 (the standard MTU > si

Re: [RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite

2024-08-28 Thread Alex Chapman
Hi, Ive been looking into the MTU terminology and would just like to clarify some naming conventions and doc strings. On 7/26/24 15:13, Nicholas Pratte wrote: +IP_HEADER_LEN = 20 +ETHER_STANDARD_FRAME = 1500 +ETHER_JUMBO_FRAME_MTU = 9000 For these constants, I am confused why one is "FRAME"

Re: [RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite

2024-08-02 Thread Jeremy Spewock
Just some very light comments here as well, mostly about doc-string but also a few questions/suggestions. On Fri, Jul 26, 2024 at 10:14 AM Nicholas Pratte wrote: > diff --git a/dts/tests/TestSuite_jumboframes.py > b/dts/tests/TestSuite_jumboframes.py > new file mode 100644 > index 00..d

[RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite

2024-07-26 Thread Nicholas Pratte
The following test suite reflects the fundamental outline for how the jumbo frames test suite may be designed. The test suite consists of five individual test cases, each of which assesses the behavior of packet transmissions for both 1518 byte and 9000 byte frames. The edge cases are ripped direc