On 12/06/2024 10:15, Juraj Linkeš wrote:
On 11. 6. 2024 11:51, Luca Vizzarro wrote:
While working on my blocklist patch, I've just realised I forgot to
add another comment. I think it would be ideal to make capabilities a
generic class, and NicCapability a child of this. When collecting
capabi
On 11. 6. 2024 11:51, Luca Vizzarro wrote:
While working on my blocklist patch, I've just realised I forgot to add
another comment. I think it would be ideal to make capabilities a
generic class, and NicCapability a child of this. When collecting
capabilities we could group these by the fina
While working on my blocklist patch, I've just realised I forgot to add
another comment. I think it would be ideal to make capabilities a
generic class, and NicCapability a child of this. When collecting
capabilities we could group these by the final class, and let this final
class create the e
On 3. 6. 2024 16:40, Nicholas Pratte wrote:
I was able to use this implementation on the in-development
jumboframes suite, setting restrictions on the required link speeds of
NICs and using this as a requirement to run all test cases. While the
framework you've developed is intuitive for true/
On 22. 5. 2024 16:58, Luca Vizzarro wrote:
Hi Juraj,
Here's my review. Excuse me for the unordinary format, but I thought
it would have just been easier to convey my suggestions through code.
Apart from the smaller suggestions, the most important one I think is
that we should make sure to enf
On Wed, Jun 5, 2024 at 9:55 AM Patrick Robb wrote:
>
>
>
> On Fri, May 31, 2024 at 12:44 PM Luca Vizzarro wrote:
>>
>>
>> In my testing of Jeremy's patches which depend on this one ("Add second
>> scatter test case"), I've discovered that the Intel E810-C NIC I am
>> using to test does not automa
On Fri, May 31, 2024 at 12:44 PM Luca Vizzarro
wrote:
>
> In my testing of Jeremy's patches which depend on this one ("Add second
> scatter test case"), I've discovered that the Intel E810-C NIC I am
> using to test does not automatically show "RX scattered packets: on".
> But I've noticed it doe
I was able to use this implementation on the in-development
jumboframes suite, setting restrictions on the required link speeds of
NICs and using this as a requirement to run all test cases. While the
framework you've developed is intuitive for true/false capabilities,
this may not be the case for
Hi again Juraj,
sorry for yet another comment!
On 11/04/2024 09:48, Juraj Linkeš wrote:
+def get_capas_rxq(
+self, supported_capabilities: MutableSet, unsupported_capabilities:
MutableSet
+) -> None:
+"""Get all rxq capabilities and divide them into supported and
unsup
I think this implementation is great, and I plan on testing it
properly with the jumbo frames suite that I am developing before
giving the final review. The only input that I could reasonably give
is a couple rewordings on the docstrings which I'll highlight below.
On Thu, Apr 11, 2024 at 4:48 AM
Hi Juraj,
Here's my review. Excuse me for the unordinary format, but I thought
it would have just been easier to convey my suggestions through code.
Apart from the smaller suggestions, the most important one I think is
that we should make sure to enforce type checking (and hinting).
Overall I lik
On 11/04/2024 09:48, Juraj Linkeš wrote:
+def get_capas_rxq(
+self, supported_capabilities: MutableSet, unsupported_capabilities:
MutableSet
+) -> None:
+"""Get all rxq capabilities and divide them into supported and
unsupported.
+
+Args:
+supported_c
The devices under test may not support the capabilities required by
various test cases. Add support for:
1. Marking test suites and test cases with required capabilities,
2. Getting which required capabilities are supported by the device under
test,
3. And then skipping test suites and test case
13 matches
Mail list logo
