Re: [RFC PATCH 11/11] bus: hide bus object

2022-09-23 Thread Thomas Monjalon
23/09/2022 10:49, David Marchand: > On Sat, Jul 9, 2022 at 6:28 PM Stephen Hemminger > wrote: > > > For now, I'll post a v2, extending the series to other internal objects. > > > We can conclude on this topic during 22.11. > > > > If you get chance to deconstruct API, switching to a numeric index

Re: [RFC PATCH 11/11] bus: hide bus object

2022-09-23 Thread David Marchand
On Sat, Jul 9, 2022 at 6:28 PM Stephen Hemminger wrote: > > > > > > > to avoid people tripping over mishandling pointers in/out of the > > > > > > > api > > > > > > > surface taking the opaque object you could declare opaque handle > > > > > > > for the > > > > > > > api to operate on instead. i

Re: [RFC PATCH 11/11] bus: hide bus object

2022-07-09 Thread Stephen Hemminger
On Sat, 9 Jul 2022 10:16:43 +0200 David Marchand wrote: > On Tue, Jun 28, 2022 at 8:23 PM Tyler Retzlaff > wrote: > > > > On Tue, Jun 28, 2022 at 10:38:27AM -0700, Stephen Hemminger wrote: > > > On Tue, 28 Jun 2022 10:07:12 -0700 > > > Tyler Retzlaff wrote: > > > > > > > > > to avoid people

Re: [RFC PATCH 11/11] bus: hide bus object

2022-07-09 Thread David Marchand
On Tue, Jun 28, 2022 at 8:23 PM Tyler Retzlaff wrote: > > On Tue, Jun 28, 2022 at 10:38:27AM -0700, Stephen Hemminger wrote: > > On Tue, 28 Jun 2022 10:07:12 -0700 > > Tyler Retzlaff wrote: > > > > > > > to avoid people tripping over mishandling pointers in/out of the api > > > > > surface taking

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 10:38:27AM -0700, Stephen Hemminger wrote: > On Tue, 28 Jun 2022 10:07:12 -0700 > Tyler Retzlaff wrote: > > > > > to avoid people tripping over mishandling pointers in/out of the api > > > > surface taking the opaque object you could declare opaque handle for the > > > > a

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Stephen Hemminger
On Tue, 28 Jun 2022 10:07:12 -0700 Tyler Retzlaff wrote: > > > to avoid people tripping over mishandling pointers in/out of the api > > > surface taking the opaque object you could declare opaque handle for the > > > api to operate on instead. it would force the use of a cast in the > > > impleme

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 09:29:05AM -0700, Stephen Hemminger wrote: > On Tue, 28 Jun 2022 09:22:13 -0700 > Tyler Retzlaff wrote: > > > On Tue, Jun 28, 2022 at 04:46:43PM +0200, David Marchand wrote: > > > Make rte_bus opaque for non internal users. > > > This will make extending this object possib

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Stephen Hemminger
On Tue, 28 Jun 2022 09:22:13 -0700 Tyler Retzlaff wrote: > On Tue, Jun 28, 2022 at 04:46:43PM +0200, David Marchand wrote: > > Make rte_bus opaque for non internal users. > > This will make extending this object possible without breaking the ABI. > > > > Introduce a new driver header and move rt

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 09:22:13AM -0700, Tyler Retzlaff wrote: > > e.g. make the opaque object an explicit type. > oops missed the typedef there but you probably know what i meant. typedef > struct { > uintptr_t opaque; > } rte_bus_handle_t; >

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 04:46:43PM +0200, David Marchand wrote: > Make rte_bus opaque for non internal users. > This will make extending this object possible without breaking the ABI. > > Introduce a new driver header and move rte_bus definition and helpers. > > Signed-off-by: David Marchand > -

[RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread David Marchand
Make rte_bus opaque for non internal users. This will make extending this object possible without breaking the ABI. Introduce a new driver header and move rte_bus definition and helpers. Signed-off-by: David Marchand --- app/test/test_devargs.c | 2 +- app/test/test_vdev.c