Re: [RFC 09/10] app/test-dma-perf: fix parsing of dma address

2024-11-14 Thread fengchengwen
On 2024/11/14 8:12, Stephen Hemminger wrote: > There was useless loop when looking at the DMA address. > It looks like it was meant to skip whitespace before > calling strtok. > > Good time to replace strtok with strtok_r as well. Incomplete modification for strtok, I suggest the strtok adopt Hai

Re: [RFC 09/10] app/test-dma-perf: fix parsing of dma address

2024-11-14 Thread Stephen Hemminger
On Thu, 14 Nov 2024 08:00:52 +0100 Morten Brørup wrote: > > + while (*addrs == '\0' && isspace(*addrs)) > > addrs++; > > This is never going to happen. Did you mean ||? Good catch.

RE: [RFC 09/10] app/test-dma-perf: fix parsing of dma address

2024-11-13 Thread Morten Brørup
> + while (*addrs == '\0' && isspace(*addrs)) > addrs++; This is never going to happen. Did you mean ||?

[RFC 09/10] app/test-dma-perf: fix parsing of dma address

2024-11-13 Thread Stephen Hemminger
There was useless loop when looking at the DMA address. It looks like it was meant to skip whitespace before calling strtok. Good time to replace strtok with strtok_r as well. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test"