Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-24 Thread Stephen Hemminger
On Thu, 24 Feb 2022 22:51:31 +0100 Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 17 February 2022 08.42 > > > > On Wed, Feb 16, 2022 at 10:10:01AM +, Bruce Richardson wrote: > > > On Wed, Feb 16, 2022 at 11:05:09AM +0100, Morten Brø

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 17 February 2022 08.42 > > On Wed, Feb 16, 2022 at 10:10:01AM +, Bruce Richardson wrote: > > On Wed, Feb 16, 2022 at 11:05:09AM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@int

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-17 Thread Tyler Retzlaff
On Wed, Feb 16, 2022 at 11:39:30AM +0100, Morten Brørup wrote: > My answer is at the end.Sent from a smartphone. Please pardon brevity and > spelling. > I am therefore wondering if we needto have our public headers > C90-compliant?/BruceWe are publicly using C11 for atomics [1]. I'm not sure >

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-17 Thread Tyler Retzlaff
On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > Yet another case of applying Linux kernel best practices > to DPDK. Flexible arrays are supported by Clang, GCC and > Microsoft compilers (part of C99). Series-Acked-by: Tyler Retzlaff subject to the outcome of documenting C99

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Tyler Retzlaff
On Wed, Feb 16, 2022 at 10:10:01AM +, Bruce Richardson wrote: > On Wed, Feb 16, 2022 at 11:05:09AM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Wednesday, 16 February 2022 10.33 > > > > > > On Tue, Feb 15, 2022 at 03:00:56PM -0800, St

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Stephen Hemminger
On Wed, 16 Feb 2022 09:33:02 + Bruce Richardson wrote: > On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > > Yet another case of applying Linux kernel best practices > > to DPDK. Flexible arrays are supported by Clang, GCC and > > Microsoft compilers (part of C99). > > >

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Morten Brørup
My answer is at the end.Sent from a smartphone. Please pardon brevity and spelling. Oprindelig besked Fra: Bruce Richardson Dato: 16/02/2022 11.15 (GMT+01:00) Til: Morten Brørup Cc: Stephen Hemminger , dev@dpdk.org Emne: Re: [RFC 0/2] Eliminate zero length arrays in DPDK

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 11:05:09AM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 16 February 2022 10.33 > > > > On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > > > Yet another case of applying Linux kernel best

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 16 February 2022 10.33 > > On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > > Yet another case of applying Linux kernel best practices > > to DPDK. Flexible arrays are supported by Clang, GCC and >

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Bruce Richardson
On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > Yet another case of applying Linux kernel best practices > to DPDK. Flexible arrays are supported by Clang, GCC and > Microsoft compilers (part of C99). > Do we need to start explicitly stating that DPDK uses C99 features, and add

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 16 February 2022 00.01 > > Yet another case of applying Linux kernel best practices > to DPDK. Flexible arrays are supported by Clang, GCC and > Microsoft compilers (part of C99). > > Stephen Hemminger (2): > devto

[RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-15 Thread Stephen Hemminger
Yet another case of applying Linux kernel best practices to DPDK. Flexible arrays are supported by Clang, GCC and Microsoft compilers (part of C99). Stephen Hemminger (2): devtools: add script to check for zero length array treewide: replace zero-length array with flex array app/test/test_ta