RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT

2024-04-22 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 22 April 2024 18.20 > > On Mon, 22 Apr 2024 17:24:43 +0200 > Morten Brørup wrote: > > > #define RTE_LOG_REGISTER_IMPL(type, name, level) \ > > - int type;

Re: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT

2024-04-22 Thread Stephen Hemminger
On Mon, 22 Apr 2024 17:24:43 +0200 Morten Brørup wrote: > #define RTE_LOG_REGISTER_IMPL(type, name, level)\ > - int type; \ > + extern int type; >

RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT

2024-04-22 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 22 April 2024 17.14 > > On Sat, 20 Apr 2024 09:48:24 +0200 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Saturday, 20 April 2024 02.08 > > > > > > The macro RTE_

Re: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT

2024-04-22 Thread Stephen Hemminger
On Sat, 20 Apr 2024 09:48:24 +0200 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Saturday, 20 April 2024 02.08 > > > > The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization > > function. If a driver (and most do) adds a semicolon aft

RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT

2024-04-20 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 20 April 2024 02.08 > > The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization > function. If a driver (and most do) adds a semicolon after the macro. > > RTE_LOG_REGISTER_DEFAULT(logtype_foo, INFO); > >

[RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT

2024-04-19 Thread Stephen Hemminger
The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization function. If a driver (and most do) adds a semicolon after the macro. RTE_LOG_REGISTER_DEFAULT(logtype_foo, INFO); Is equivalent to: int logtype_foo; static void __logtype_foo(void) { logtype_foo = rt