RE: [RFC] cryptodev: refactor sm2, add plain message flag

2024-01-19 Thread Akhil Goyal
Hi Ciara/Arek, > Hi Akhil, > > > -Original Message- > > From: Kusztal, ArkadiuszX > > Sent: Friday, August 11, 2023 6:40 PM > > To: dev@dpdk.org > > Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara > > ; Kusztal, ArkadiuszX > > > Subjec

RE: [RFC] cryptodev: refactor sm2, add plain message flag

2023-10-04 Thread Power, Ciara
Hi Akhil, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, August 11, 2023 6:40 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara > ; Kusztal, ArkadiuszX > Subject: [RFC] cryptodev: refactor sm2, add plain message flag >

RE: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag

2023-09-20 Thread Gowrishankar Muthukrishnan
Hi, > Actually hash should be moved outside of xform, we do not want to have a > session per hash I think. > Session should be per key, eventually per private key only. > > If a hardware does not support hashing plain input before any SM2 op, It has to be first hashed in a separate session (based

RE: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag

2023-09-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday, August 14, 2023 9:49 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Akhil Goyal ; Ji, Kai ; Power, Ciara > > Subject: RE: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag >

RE: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag

2023-08-14 Thread Gowrishankar Muthukrishnan
Hi, Please find my comments inline. At the same time, may I request you to review my patch series : https://patches.dpdk.org/project/dpdk/list/?series=29149 > SM2 asymmetric crypto operation was split into cipher and signature > operation. Now it corresponds to the other crypto algorithms and fac

[RFC] cryptodev: refactor sm2, add plain message flag

2023-08-11 Thread Arkadiusz Kusztal
SM2 asymmetric crypto operation was split into cipher and signature operation. Now it corresponds to the other crypto algorithms and facilitates addition of other SM2 components like the SM2 key exchange. Flag to distinguish between a plain message or a hash used for signature was added to the DSA