Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 13:44, Gregory Etelson wrote: Hello Andrew, [] On 2/2/23 13:24, Gregory Etelson wrote: On 2/1/23 18:16, Gregory Etelson wrote: + ops = rte_flow_ops_get(port_id, error); + if (!ops || !ops->action_handle_query_update) + return -ENOTSUP; May be it makes sense to

RE: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Gregory Etelson
Hello Andrew, [] > On 2/2/23 13:24, Gregory Etelson wrote: > >> On 2/1/23 18:16, Gregory Etelson wrote: > >>> + ops = rte_flow_ops_get(port_id, error); > >>> + if (!ops || !ops->action_handle_query_update) > >>> + return -ENOTSUP; > >> > >> May be it makes sense to use single-

Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 13:24, Gregory Etelson wrote: On 2/1/23 18:16, Gregory Etelson wrote: + ops = rte_flow_ops_get(port_id, error); + if (!ops || !ops->action_handle_query_update) + return -ENOTSUP; May be it makes sense to use single-operation callbacks if another operation input is

RE: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Gregory Etelson
Hello Andrew, Please check out my comments below. Regards, Gregory > > > query_update is bad for summary, consider something like > ethdev: add query and update sync and async API > Will fix in v9. > On 2/1/23 18:16, Gregory Etelson wrote: > > Current API allows either query or update indir

Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-02 Thread Andrew Rybchenko
query_update is bad for summary, consider something like ethdev: add query and update sync and async API On 2/1/23 18:16, Gregory Etelson wrote: Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state applic

RE: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Ori Kam
henko > Subject: [PATCH v8 1/2] ethdev: add query_update sync and async function > calls > > Current API allows either query or update indirect flow action. > If indirect action must be conditionally updated according to it's > present state application must first issu

[PATCH v8 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Gregory Etelson
Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When the update will be processed, action state c