Re: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-14 Thread Andrew Rybchenko
On 2/13/23 13:25, Morten Brørup wrote: From: Olivier Matz [mailto:olivier.m...@6wind.com] Sent: Monday, 13 February 2023 10.37 Hello, Thank you for this work, and sorry for the late feedback too. Better late than never. And it's a core library, so important to get it right! On Mon, Feb 13,

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-13 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 13 February 2023 10.37 > > Hello, > > Thank you for this work, and sorry for the late feedback too. Better late than never. And it's a core library, so important to get it right! > > On Mon, Feb 13, 2023 at 04:29:51AM +,

Re: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-13 Thread Olivier Matz
Hello, Thank you for this work, and sorry for the late feedback too. On Mon, Feb 13, 2023 at 04:29:51AM +, Honnappa Nagarahalli wrote: > > > > > > +/** > > > > + * @internal used by rte_mempool_cache_zc_put_bulk() and > > > > rte_mempool_do_generic_put(). > > > > + * > > > > + * Zero-copy p

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-13 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Monday, 13 February 2023 05.30 > > > > > > > +/** > > > > + * @internal used by rte_mempool_cache_zc_put_bulk() and > > > > rte_mempool_do_generic_put(). > > > > + * > > > > + * Zero-copy put objects in a mempool cache ba

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-12 Thread Honnappa Nagarahalli
> > > +/** > > > + * @internal used by rte_mempool_cache_zc_put_bulk() and > > > rte_mempool_do_generic_put(). > > > + * > > > + * Zero-copy put objects in a mempool cache backed by the specified > > > mempool. > > > + * > > > + * @param cache > > > + * A pointer to the mempool cache. > > > + *

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-12 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Sunday, 12 February 2023 20.57 > > Hi Morten, > Apologies for the late comments. Better late than never. :-) > > > From: Morten Brørup > > Sent: Thursday, February 9, 2023 8:59 AM > > > > Zero-copy access to mempo

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-12 Thread Honnappa Nagarahalli
chard...@intel.com; > konstantin.anan...@huawei.com; dev@dpdk.org > Cc: nd ; david.march...@redhat.com; Morten Brørup > > Subject: [PATCH v8] mempool cache: add zero-copy get and put functions > > Zero-copy access to mempool caches is beneficial for PMD performance, and > must be prov

Re: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-10 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/9 22:58, Morten Brørup wrote: > Zero-copy access to mempool caches is beneficial for PMD performance, and > must be provided by the mempool library to fix [Bug 1052] without a > performance regression. > > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052 >

[PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-09 Thread Morten Brørup
Zero-copy access to mempool caches is beneficial for PMD performance, and must be provided by the mempool library to fix [Bug 1052] without a performance regression. [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052 Bugzilla ID: 1052 Signed-off-by: Morten Brørup Acked-by: Konstantin Ananye