Re: [PATCH v7 08/39] mbuf: use C11 alignas

2024-03-05 Thread David Marchand
On Tue, Mar 5, 2024 at 6:37 PM Tyler Retzlaff wrote: > > > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > > > index 5688683..917a811 100644 > > > --- a/lib/mbuf/rte_mbuf_core.h > > > +++ b/lib/mbuf/rte_mbuf_core.h > > > @@ -463,7 +463,7 @@ enum { > > > /** > > > * The generi

Re: [PATCH v7 08/39] mbuf: use C11 alignas

2024-03-05 Thread Tyler Retzlaff
On Tue, Mar 05, 2024 at 03:30:49PM +0100, David Marchand wrote: > On Mon, Mar 4, 2024 at 6:54 PM Tyler Retzlaff > wrote: > > > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > location accepted by both

Re: [PATCH v7 08/39] mbuf: use C11 alignas

2024-03-05 Thread David Marchand
On Mon, Mar 4, 2024 at 6:54 PM Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > and variables is not compatible with MSVC. There is only a single > location accepted by both toolchains. > > For variables standard C11 offers alignas(a) supported by c

[PATCH v7 08/39] mbuf: use C11 alignas

2024-03-04 Thread Tyler Retzlaff
The current location used for __rte_aligned(a) for alignment of types and variables is not compatible with MSVC. There is only a single location accepted by both toolchains. For variables standard C11 offers alignas(a) supported by conformant compilers i.e. both MSVC and GCC. For types the standa