Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-10-03 Thread Kevin Laatz
Hi David, On 03/10/2022 13:35, David Marchand wrote: Hello Bruce, Kevin, On Mon, Jun 13, 2022 at 5:59 PM Bruce Richardson wrote: For info, Li has sent a patch for the bus cleanup which is not updating the bus code: https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-3-l...@nvidi

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-10-03 Thread David Marchand
Hello Bruce, Kevin, On Mon, Jun 13, 2022 at 5:59 PM Bruce Richardson wrote: > > > For info, Li has sent a patch for the bus cleanup > > > which is not updating the bus code: > > > https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-3-l...@nvidia.com/ > > > It may be a temporary solu

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-13 Thread Bruce Richardson
On Tue, Jun 07, 2022 at 05:12:02PM +0200, David Marchand wrote: > On Tue, Jun 7, 2022 at 1:09 PM Thomas Monjalon wrote: > > > > 03/06/2022 16:36, Kevin Laatz: > > > During EAL init, all buses are probed and the devices found are > > > initialized. On eal_cleanup(), the inverse does not happen, mea

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 1:09 PM Thomas Monjalon wrote: > > 03/06/2022 16:36, Kevin Laatz: > > During EAL init, all buses are probed and the devices found are > > initialized. On eal_cleanup(), the inverse does not happen, meaning any > > allocated memory and other configuration will not be cleaned

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-07 Thread Thomas Monjalon
03/06/2022 16:36, Kevin Laatz: > During EAL init, all buses are probed and the devices found are > initialized. On eal_cleanup(), the inverse does not happen, meaning any > allocated memory and other configuration will not be cleaned up > appropriately on exit. [...] > --- a/devtools/libabigail.abi

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Bruce Richardson
On Fri, Jun 03, 2022 at 08:11:54AM -0700, Stephen Hemminger wrote: > On Fri, 3 Jun 2022 15:36:01 +0100 > Kevin Laatz wrote: > > > +/* Clean up all devices of all buses */ > > +int > > +eal_bus_cleanup(void) > > +{ > > + int ret = 0; > > + struct rte_bus *bus; > > + > > + TAILQ_FOREACH(bus,

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Stephen Hemminger
On Fri, 3 Jun 2022 15:36:01 +0100 Kevin Laatz wrote: > +/* Clean up all devices of all buses */ > +int > +eal_bus_cleanup(void) > +{ > + int ret = 0; > + struct rte_bus *bus; > + > + TAILQ_FOREACH(bus, &rte_bus_list, next) { > + if (bus->cleanup == NULL) > +

[PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-03 Thread Kevin Laatz
During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up appropriately on exit. Currently, in order for device cleanup to take place, applications must cal