Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-03 Thread Ferruh Yigit
On 2/3/2023 3:12 PM, Thomas Monjalon wrote: > 03/02/2023 16:02, Ferruh Yigit: >> On 2/2/2023 5:16 PM, Thomas Monjalon wrote: >>> 02/02/2023 13:44, Ferruh Yigit: --- a/lib/net/rte_gre.h +++ b/lib/net/rte_gre.h @@ -28,6 +28,8 @@ extern "C" { */ __extension__ struct r

Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-03 Thread Thomas Monjalon
03/02/2023 16:02, Ferruh Yigit: > On 2/2/2023 5:16 PM, Thomas Monjalon wrote: > > 02/02/2023 13:44, Ferruh Yigit: > >> --- a/lib/net/rte_gre.h > >> +++ b/lib/net/rte_gre.h > >> @@ -28,6 +28,8 @@ extern "C" { > >> */ > >> __extension__ > >> struct rte_gre_hdr { > >> + union { > >> +

Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-03 Thread Ferruh Yigit
On 2/2/2023 5:16 PM, Thomas Monjalon wrote: > 02/02/2023 13:44, Ferruh Yigit: >> --- a/lib/net/rte_gre.h >> +++ b/lib/net/rte_gre.h >> @@ -28,6 +28,8 @@ extern "C" { >> */ >> __extension__ >> struct rte_gre_hdr { >> + union { >> + struct { >> #if RTE_BYTE_ORDER == RTE_LITTL

Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-02 Thread Thomas Monjalon
02/02/2023 13:44, Ferruh Yigit: > --- a/lib/net/rte_gre.h > +++ b/lib/net/rte_gre.h > @@ -28,6 +28,8 @@ extern "C" { > */ > __extension__ > struct rte_gre_hdr { > + union { > + struct { > #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > uint16_t res2:4; /**< Reserved */ >

[PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GRE header struct members are used in apps and drivers ins