Re: [PATCH v6 2/5] power: refactor uncore power management library

2024-10-20 Thread Stephen Hemminger
On Sun, 20 Oct 2024 09:22:29 + Sivaprasad Tummala wrote: > +uint32_t > +rte_power_get_uncore_freq(unsigned int pkg, unsigned int die) > +{ > + RTE_ASSERT(global_uncore_ops != NULL); All these RTE_ASSERT calls seem like a good idea, they really don't help. If RTE_ASSERT fails it prints a

Re: [PATCH v6 2/5] power: refactor uncore power management library

2024-10-20 Thread Stephen Hemminger
On Sun, 20 Oct 2024 09:22:29 + Sivaprasad Tummala wrote: > diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c > index 48c75a5da0..f11238cc34 100644 > --- a/lib/power/rte_power_uncore.c > +++ b/lib/power/rte_power_uncore.c > @@ -10,100 +10,53 @@ > > #include "power_com

[PATCH v6 2/5] power: refactor uncore power management library

2024-10-20 Thread Sivaprasad Tummala
iThis patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. Thi