Hi Cristian,
> > By default TC OV is disabled.
> > History:
> > - v1 - TC OV disabled by default
> > - v2 - throughput improvements
> > - v3, v4, v5 - changes from comments
> > - v6 - removed rte_sched_subport_tc_ov_config declaration and map
>
> The place of the history log is not here. If you
Hi Cristian,
>
> Using a switch statement for a binary condition instead of if-else does not
> make sense to me. I know you mention you saw better performance with the
> switch, but I am pretty sure it is not the switch providing the performance
> increase. You are using if-else for testing the
Hi Cristian,
Thank you for comments. Please find my response inline.
> > Signed-off-by: Marcin Danilewicz
> > ---
> > lib/sched/rte_sched.c | 96
> > +--
> > 1 file changed, 93 insertions(+), 3 deletions(-)
> >
> This latest version of your patch only con
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Monday, May 30, 2022 9:45 AM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v6] sched: enable traffic class oversubscription conditionally
>
>
Hi Marcin,
Comments inline below.
> @@ -2403,8 +2481,16 @@ grinder_schedule(struct rte_sched_port *port,
> uint32_t pkt_len = pkt->pkt_len + port->frame_overhead;
> uint32_t be_tc_active;
>
> - if (!grinder_credits_check(port, subport, pos))
> - return 0;
> + sw
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Monday, May 30, 2022 9:45 AM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v6] sched: enable traffic class oversubscription conditionally
>
>
Added new API to enable or disable TC over subscription for best
effort traffic class at subport level.
Added changes after review and increased throughput.
By default TC OV is disabled.
History:
- v1 - TC OV disabled by default
- v2 - throughput improvements
- v3, v4, v5 - changes from comments
-
7 matches
Mail list logo
