Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Robin Jarry
Kevin Laatz, Jan 18, 2023 at 17:01: > The additional endpoint(s) (I like Morten's idea of a single additional > endpoint where you can specify the metrics to include via parameters) > shouldn't affect the format of other parts of this patchset, but we > would gain the benefits of the additional

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 18/01/2023 14:45, Robin Jarry wrote: Kevin Laatz, Jan 18, 2023 at 10:42: Hi Robin, Thanks for taking the time to work on this. It is a good implementation for debug use-cases. I have 2 suggestions which would improve the usability of the data: 1. Could we make the lcore_id paramater on /eal

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Robin Jarry
Kevin Laatz, Jan 18, 2023 at 10:42: > Hi Robin, > > Thanks for taking the time to work on this. It is a good implementation > for debug use-cases. > > I have 2 suggestions which would improve the usability of the data: > 1. Could we make the lcore_id paramater on /eal/lcore/info optional? > This

RE: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Morten Brørup
> From: Kevin Laatz [mailto:kevin.la...@intel.com] > Sent: Wednesday, 18 January 2023 12.03 > > On 18/01/2023 10:21, Morten Brørup wrote: > >> From: Kevin Laatz [mailto:kevin.la...@intel.com] > >> > >> On 16/12/2022 10:21, Robin Jarry wrote: > >>> Report the same information than rte_lcore_dump()

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 18/01/2023 10:21, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Wednesday, 18 January 2023 10.42 To: Robin Jarry; dev@dpdk.org Cc: Tyler Retzlaff; Morten Brørup Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry On 16/12/2022 10:21, Robin Jarry wrote

RE: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Morten Brørup
> From: Kevin Laatz [mailto:kevin.la...@intel.com] > Sent: Wednesday, 18 January 2023 10.42 > To: Robin Jarry; dev@dpdk.org > Cc: Tyler Retzlaff; Morten Brørup > Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry > > On 16/12/2022 10:21, Robin Jarry wrote

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

2023-01-18 Thread Kevin Laatz
On 16/12/2022 10:21, Robin Jarry wrote: Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cp

[PATCH v5 1/4] eal: add lcore info in telemetry

2022-12-16 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-