Re: [PATCH v5] virtio: optimize stats counters performance

2024-09-19 Thread Maxime Coquelin
On 8/1/24 18:03, Morten Brørup wrote: Optimized the performance of updating the virtio statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brørup --- v5: * Do not in

Re: [PATCH v5] virtio: optimize stats counters performance

2024-09-10 Thread Maxime Coquelin
On 8/1/24 18:03, Morten Brørup wrote: Optimized the performance of updating the virtio statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brørup --- v5: * Do not in

Re: [PATCH v5] virtio: optimize stats counters performance

2024-08-06 Thread Chenbo Xia
> On Aug 2, 2024, at 00:03, Morten Brørup wrote: > > External email: Use caution opening links or attachments > > > Optimized the performance of updating the virtio statistics counters by > reducing the number of branches. > > Ordered the packet size comparisons according to the probability

Re: [PATCH v5] virtio: optimize stats counters performance

2024-08-04 Thread lihuisong (C)
LGTM, Acked-by: Huisong Li 在 2024/8/2 0:03, Morten Brørup 写道: Optimized the performance of updating the virtio statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brø

Re: [PATCH v5] virtio: optimize stats counters performance

2024-08-04 Thread lihuisong (C)
在 2024/8/2 19:27, Morten Brørup 写道: From: lihuisong (C) [mailto:lihuis...@huawei.com] Sent: Friday, 2 August 2024 04.23 在 2024/8/2 0:03, Morten Brørup 写道: void -virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) +virtio_update_packet_stats(struct virtnet_stats

RE: [PATCH v5] virtio: optimize stats counters performance

2024-08-02 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, 1 August 2024 22.38 > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, 1 August 2024 18.18 > > > > On Thu, 1 Aug 2024 16:03:12 + > > Morten Brørup wrote: > > > > > Optimized the per

RE: [PATCH v5] virtio: optimize stats counters performance

2024-08-02 Thread Morten Brørup
> From: lihuisong (C) [mailto:lihuis...@huawei.com] > Sent: Friday, 2 August 2024 04.23 > > 在 2024/8/2 0:03, Morten Brørup 写道: > > void > > -virtio_update_packet_stats(struct virtnet_stats *stats, struct > rte_mbuf *mbuf) > > +virtio_update_packet_stats(struct virtnet_stats *const stats, > > +

Re: [PATCH v5] virtio: optimize stats counters performance

2024-08-01 Thread lihuisong (C)
在 2024/8/2 10:42, Stephen Hemminger 写道: On Fri, 2 Aug 2024 10:23:12 +0800 "lihuisong (C)" wrote: void -virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) +virtio_update_packet_stats(struct virtnet_stats *const stats, + const struct rte_mbuf *const

Re: [PATCH v5] virtio: optimize stats counters performance

2024-08-01 Thread lihuisong (C)
在 2024/8/2 0:03, Morten Brørup 写道: Optimized the performance of updating the virtio statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brørup --- v5: * Do not inline

RE: [PATCH v5] virtio: optimize stats counters performance

2024-08-01 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 1 August 2024 18.18 > > On Thu, 1 Aug 2024 16:03:12 + > Morten Brørup wrote: > > > Optimized the performance of updating the virtio statistics counters > by > > reducing the number of branches. > > > > Ordered t

[PATCH v5] virtio: optimize stats counters performance

2024-08-01 Thread Morten Brørup
Optimized the performance of updating the virtio statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brørup --- v5: * Do not inline the function. (Stephen) v4: * Consider