Re: [PATCH v5] testpmd: go back to using cmdline_interact

2023-03-19 Thread Thomas Monjalon
17/03/2023 22:12, Olivier Matz: > On Fri, Mar 17, 2023 at 09:59:41AM -0700, Stephen Hemminger wrote: > > The cmdline_poll() function is broken and was > > not fully tested, don't use it. > > > > Instead, use sigaction() to cancel read character on Unix OS's > > and a new helper to cancel I/O on Wi

Re: [PATCH v5] testpmd: go back to using cmdline_interact

2023-03-17 Thread Olivier Matz
On Fri, Mar 17, 2023 at 09:59:41AM -0700, Stephen Hemminger wrote: > The cmdline_poll() function is broken and was > not fully tested, don't use it. > > Instead, use sigaction() to cancel read character on Unix OS's > and a new helper to cancel I/O on Windows. > > Fixes: 0fd1386c30c3 ("app/testpm

[PATCH v5] testpmd: go back to using cmdline_interact

2023-03-17 Thread Stephen Hemminger
The cmdline_poll() function is broken and was not fully tested, don't use it. Instead, use sigaction() to cancel read character on Unix OS's and a new helper to cancel I/O on Windows. Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") Bugzilla ID: 1180 Signed-off-by: Stephen Hemming