Makes sense, I'll send out a new version soon
Alright scratch that then. The only thing I'd change Dean is the name of
the method. Saying testsuite is somewhat redundant, I think just log fine.
I think it makes sense to keep logger private and separate. I can see
one reason - we can change the logger in the framework without affecting
the tests. We can also decide to not use the logger to print test suites
messages - for example save per test artifacts.
On 15/01/2025 10:17, Luca Vizzarro
Sorry for the late reply Dean. This is a bit redundant in my opinion,
there is no reason not to give full access to the test suite's own
logger. I'd just change TestSuite._logger into TestSuite.logger to
indicate that it's a public member, and do what you initially did.
Add a test suite to replace hello_world which simply
starts and stops a testpmd session. The user can use
this as a confidence check to verify their configuration.
Signed-off-by: Dean Marx
Reviewed-by: Paul Szczepanek
Reviewed-by: Luca Vizzarro
---
dts/framework/test_suite.py| 10 +
5 matches
Mail list logo
