Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-07 Thread Andrew Rybchenko
On 6/7/22 00:30, Thomas Monjalon wrote: It seems we share a common understanding and we need to agree on a good wording for the most meaningful API. Questions inline below: 06/06/2022 19:15, Andrew Rybchenko: On 6/6/22 16:16, Spike Du wrote: Hi Andrew, Please see below for "fill thresh

RE: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-06 Thread Spike Du
m; > dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold > > External email: Use caution opening links or attachments > > > On 6/6/22 16:16, Spike Du wrote: > > Hi Andrew, > > Please see below for

Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-06 Thread Thomas Monjalon
It seems we share a common understanding and we need to agree on a good wording for the most meaningful API. Questions inline below: 06/06/2022 19:15, Andrew Rybchenko: > On 6/6/22 16:16, Spike Du wrote: > > Hi Andrew, > > Please see below for "fill threshold" concept, I'm ok with other > > c

Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-06 Thread Andrew Rybchenko
Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Wenzhuo Lu ; Beilei Xing ; Bernard Iremonger ; Ray Kinsella ; Neil Horman Cc: step...@networkplumber.org; m...@smartsharesystems.com; dev@dpdk.org; Raslan Darawsheh Subject: Re: [PATCH v4 3/7] ethdev: introduce Rx queue based

Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-06 Thread Stephen Hemminger
On Fri, 3 Jun 2022 15:48:17 +0300 Spike Du wrote: > Fill threshold describes the fullness of a Rx queue. If the Rx > queue fullness is above the threshold, the device will trigger the event > RTE_ETH_EVENT_RX_FILL_THRESH. > Fill threshold is defined as a percentage of Rx queue size with valid > v

RE: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-06 Thread Spike Du
enko ; Ori Kam ; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Wenzhuo Lu ; Beilei Xing ; > Bernard Iremonger ; Ray Kinsella > ; Neil Horman > Cc: step...@networkplumber.org; m...@smartsharesystems.com; > dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH v4 3/7] ethdev: introduc

Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-04 Thread Andrew Rybchenko
On 6/3/22 15:48, Spike Du wrote: Fill threshold describes the fullness of a Rx queue. If the Rx queue fullness is above the threshold, the device will trigger the event RTE_ETH_EVENT_RX_FILL_THRESH. Sorry, I'm not sure that I understand. As far as I know the process to add more Rx buffers to Rx

Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-03 Thread Ray Kinsella
Spike Du writes: > Fill threshold describes the fullness of a Rx queue. If the Rx > queue fullness is above the threshold, the device will trigger the event > RTE_ETH_EVENT_RX_FILL_THRESH. > Fill threshold is defined as a percentage of Rx queue size with valid > value of [0,99]. > Setting fill

[PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-03 Thread Spike Du
Fill threshold describes the fullness of a Rx queue. If the Rx queue fullness is above the threshold, the device will trigger the event RTE_ETH_EVENT_RX_FILL_THRESH. Fill threshold is defined as a percentage of Rx queue size with valid value of [0,99]. Setting fill threshold to 0 means disable it,