Re: [PATCH v4 2/4] dts: improve starting and stopping interactive shells

2024-06-18 Thread Jeremy Spewock
On Tue, Jun 18, 2024 at 11:54 AM Juraj Linkeš wrote: > > > @@ -15,18 +18,34 @@ class InteractiveShell(SingleActiveInteractiveShell): > > > +def _start_application(self, get_privileged_command: Callable[[str], > > str] | None) -> None: > > +"""Overrides :meth:`_start_application` in th

Re: [PATCH v4 2/4] dts: improve starting and stopping interactive shells

2024-06-18 Thread Juraj Linkeš
@@ -15,18 +18,34 @@ class InteractiveShell(SingleActiveInteractiveShell): +def _start_application(self, get_privileged_command: Callable[[str], str] | None) -> None: +"""Overrides :meth:`_start_application` in the parent class. + +Add a weakref finalize class after starting

[PATCH v4 2/4] dts: improve starting and stopping interactive shells

2024-06-13 Thread jspewock
From: Jeremy Spewock The InteractiveShell class currently relies on being cleaned up and shutdown at the time of garbage collection, but this cleanup of the class does no verification that the session is still running prior to cleanup. So, if a user were to call this method themselves prior to ga