Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-06 Thread fengchengwen
Hi Stephen, On 2023/11/7 0:19, Stephen Hemminger wrote: > On Mon, 6 Nov 2023 15:13:35 +0800 > fengchengwen wrote: > + >>> >>> Looks good but may I suggest some alternatives. >>> >>> Since this is an API and ABI change as was not announced, maybe a little >>> late >>> in the process for t

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-06 Thread Stephen Hemminger
On Mon, 6 Nov 2023 15:13:35 +0800 fengchengwen wrote: > >> + > > > > Looks good but may I suggest some alternatives. > > > > Since this is an API and ABI change as was not announced, maybe a little > > late > > in the process for this release. And since unlikely to go in 23.11 need to > > d

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-05 Thread fengchengwen
Hi Stephen, On 2023/11/6 11:18, Stephen Hemminger wrote: > On Sun, 5 Nov 2023 05:45:35 + > Chengwen Feng wrote: > >> +* **Updated kvargs process API.** >> + >> + * Introduced rte_kvargs_process_opt() API, which inherits the function >> +of rte_kvargs_process() and could handle both key=

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-05 Thread Stephen Hemminger
On Sun, 5 Nov 2023 05:45:35 + Chengwen Feng wrote: > +* **Updated kvargs process API.** > + > + * Introduced rte_kvargs_process_opt() API, which inherits the function > +of rte_kvargs_process() and could handle both key=value and only-key > +cases. > + > + * Constraint rte_kvargs_pr

[PATCH v4 1/5] kvargs: add one new process API

2023-11-04 Thread Chengwen Feng
The rte_kvargs_process() was used to handle key=value (e.g. socket_id=0), it also supports to handle only-key (e.g. socket_id). But many drivers's callback can only handle key=value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified to