Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Ferruh Yigit
On 9/21/2022 8:58 AM, Ferruh Yigit wrote: On 9/20/2022 8:15 PM, Robin Jarry wrote: Ferruh Yigit, Sep 20, 2022 at 19:48: +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid JSON only. +  PCI-IDs parsing has been removed. +  To get a similar output to the (now removed) ``-r/--raw`

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Ferruh Yigit
On 9/21/2022 8:27 AM, Thomas Monjalon wrote: 20/09/2022 19:50, Ferruh Yigit: Thomas, John, Should we have documentation for usertools, since they are user facing, what do you think? We have doc/guides/tools/ Indeed, and there is even 'doc/guides/tools/pmdinfo.rst', so @Robin that documenta

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Ferruh Yigit
On 9/20/2022 8:15 PM, Robin Jarry wrote: Ferruh Yigit, Sep 20, 2022 at 19:48: +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid JSON only. + PCI-IDs parsing has been removed. + To get a similar output to the (now removed) ``-r/--raw`` flag, you may use the following command::

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Thomas Monjalon
20/09/2022 19:50, Ferruh Yigit: > Thomas, John, > > Should we have documentation for usertools, since they are user facing, > what do you think? We have doc/guides/tools/ > Can it be possible to find resource for it?

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-20 Thread Robin Jarry
Ferruh Yigit, Sep 20, 2022 at 19:48: > > +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid JSON only. > > + PCI-IDs parsing has been removed. > > + To get a similar output to the (now removed) ``-r/--raw`` flag, you may > > use the following command:: > > + > > + strings $dpdk

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-20 Thread Ferruh Yigit
On 9/20/2022 6:48 PM, Ferruh Yigit wrote: On 9/20/2022 11:42 AM, Robin Jarry wrote: dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-20 Thread Ferruh Yigit
On 9/20/2022 11:42 AM, Robin Jarry wrote: dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather high for such a simple task: extracting PMD

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-20 Thread Olivier Matz
On Tue, Sep 20, 2022 at 12:42:12PM +0200, Robin Jarry wrote: > dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag > merely prints multiple independent JSON lines which cannot be fed > directly to any JSON parser. Moreover, the script complexity is rather > high for such a simp

[PATCH v4] usertools: rewrite pmdinfo

2022-09-20 Thread Robin Jarry
dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather high for such a simple task: extracting PMD_INFO_STRING from .rodata ELF sections. Rewrit