Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-02-07 Thread Stephen Hemminger
On Wed, 5 Feb 2025 11:32:24 -0800 Andre Muezerie wrote: > This patch avoids warnings like the ones below emitted by MSVC: > > 1) > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > >

Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-02-07 Thread Andre Muezerie
On Fri, Feb 07, 2025 at 03:56:42PM +, Bruce Richardson wrote: > On Fri, Feb 07, 2025 at 07:46:03AM -0800, Andre Muezerie wrote: > > On Thu, Feb 06, 2025 at 11:07:32AM +, Bruce Richardson wrote: > > > On Wed, Feb 05, 2025 at 11:32:24AM -0800, Andre Muezerie wrote: > > > > This patch avoids w

Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-02-07 Thread Bruce Richardson
On Fri, Feb 07, 2025 at 07:46:03AM -0800, Andre Muezerie wrote: > On Thu, Feb 06, 2025 at 11:07:32AM +, Bruce Richardson wrote: > > On Wed, Feb 05, 2025 at 11:32:24AM -0800, Andre Muezerie wrote: > > > This patch avoids warnings like the ones below emitted by MSVC: > > > > > > 1) > > > ../driv

Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-02-07 Thread Andre Muezerie
On Thu, Feb 06, 2025 at 11:07:32AM +, Bruce Richardson wrote: > On Wed, Feb 05, 2025 at 11:32:24AM -0800, Andre Muezerie wrote: > > This patch avoids warnings like the ones below emitted by MSVC: > > > > 1) > > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > > result of 32

Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-02-06 Thread Bruce Richardson
On Wed, Feb 05, 2025 at 11:32:24AM -0800, Andre Muezerie wrote: > This patch avoids warnings like the ones below emitted by MSVC: > > 1) > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?)

[PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-02-05 Thread Andre Muezerie
This patch avoids warnings like the ones below emitted by MSVC: 1) ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) 2) ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=': signed