RE: [PATCH v3 28/33] net/ena/hal: cosmetic changes

2024-03-12 Thread Brandes, Shai
> -Original Message- > From: Ferruh Yigit > Sent: Friday, March 8, 2024 7:45 PM > To: Brandes, Shai > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v3 28/33] net/ena/hal: cosmetic changes > > CAUTION: This email originated from outside of the organization.

Re: [PATCH v3 28/33] net/ena/hal: cosmetic changes

2024-03-08 Thread Ferruh Yigit
On 3/8/2024 5:43 PM, Ferruh Yigit wrote: > On 3/6/2024 12:24 PM, shaib...@amazon.com wrote: >> From: Shai Brandes >> >> 1. modify log prints to use correct format specifier >>for unsigned variables. >> > > I am not user using correct format specifier is cosmetic change, perhaps > we don't und

Re: [PATCH v3 28/33] net/ena/hal: cosmetic changes

2024-03-08 Thread Ferruh Yigit
On 3/6/2024 12:24 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > 1. modify log prints to use correct format specifier >for unsigned variables. > I am not user using correct format specifier is cosmetic change, perhaps we don't understand same thing, can you please define "cosmetic c

[PATCH v3 28/33] net/ena/hal: cosmetic changes

2024-03-06 Thread shaibran
From: Shai Brandes 1. modify log prints to use correct format specifier for unsigned variables. 2. removed line breaks for lines that do not exceed maximal line length. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_eth_com.c | 22 +++--