RE: [PATCH v3 2/9] net/gve: add logs and OS specific implementation

2022-09-27 Thread Guo, Junfeng
gt; Wang, Haiyue > Subject: Re: [PATCH v3 2/9] net/gve: add logs and OS specific > implementation > > On Fri, 23 Sep 2022 17:38:22 +0800 > Junfeng Guo wrote: > > > + > > +#define PMD_DRV_LOG(level, fmt, args...) \ > > + rte_log(RTE_LOG_ ## level, gve_

Re: [PATCH v3 2/9] net/gve: add logs and OS specific implementation

2022-09-23 Thread Stephen Hemminger
On Fri, 23 Sep 2022 17:38:22 +0800 Junfeng Guo wrote: > + > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n", \ > + __func__, ## args) Many of your existing log messages already have newline, so using this common def

[PATCH v3 2/9] net/gve: add logs and OS specific implementation

2022-09-23 Thread Junfeng Guo
Add GVE PMD logs. Add some MACRO definitions and memory operations which are specific for DPDK. Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/gve_adminq.h | 2 + drivers/net/gve/gve_desc.h | 2 + drivers/net/gve/gve_desc_dqo.h |