Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-12 Thread Juraj Linkeš
On 11. 6. 2024 17:33, Jeremy Spewock wrote: On Tue, Jun 11, 2024 at 5:17 AM Juraj Linkeš wrote: On 10. 6. 2024 22:06, Jeremy Spewock wrote: Overall, my thoughts are that it's definitely an interesting idea to make the normal shell subclass the critical. I explain more below, but basicall

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-11 Thread Jeremy Spewock
On Tue, Jun 11, 2024 at 5:17 AM Juraj Linkeš wrote: > > > > On 10. 6. 2024 22:06, Jeremy Spewock wrote: > > Overall, my thoughts are that it's definitely an interesting idea to > > make the normal shell subclass the critical. I explain more below, but > > basically I think it makes sense as long a

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-11 Thread Juraj Linkeš
On 10. 6. 2024 22:06, Jeremy Spewock wrote: Overall, my thoughts are that it's definitely an interesting idea to make the normal shell subclass the critical. I explain more below, but basically I think it makes sense as long as we are fine with the normal shells having a context manager which

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-10 Thread Jeremy Spewock
Overall, my thoughts are that it's definitely an interesting idea to make the normal shell subclass the critical. I explain more below, but basically I think it makes sense as long as we are fine with the normal shells having a context manager which likely won't really be used since it doesn't real

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-10 Thread Juraj Linkeš
It seems to me the patch would benefit from Luca's testpmd changes, mainly how the Shell is created. Not sure if we actually want to do that with this series, but it sound enticing. diff --git a/dts/framework/remote_session/critical_interactive_shell.py b/dts/framework/remote_session/critical

[PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-05 Thread jspewock
From: Jeremy Spewock Interactive shells are managed in a way currently where they are closed and cleaned up at the time of garbage collection. Due to there being no guarantee of when this garbage collection happens in Python, there is no way to consistently know when an application will be closed