Re: [PATCH v3 12/27] net/nfp: refact the hwinfo module

On 9/18/2023 2:39 AM, Chaoyong He wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, September 15, 2023 9:46 PM >> To: Chaoyong He ; dev@dpdk.org >> Cc: oss-drivers ; Niklas Soderlund >> >> Subject: Re: [PATCH v3 12/

RE: [PATCH v3 12/27] net/nfp: refact the hwinfo module

> -Original Message- > From: Ferruh Yigit > Sent: Friday, September 15, 2023 9:46 PM > To: Chaoyong He ; dev@dpdk.org > Cc: oss-drivers ; Niklas Soderlund > > Subject: Re: [PATCH v3 12/27] net/nfp: refact the hwinfo module > > On 9/15/2023 10:15 AM, Chao

Re: [PATCH v3 12/27] net/nfp: refact the hwinfo module

On 9/15/2023 10:15 AM, Chaoyong He wrote: > Move the definition of data structure and macro into the implement file. > What is the motivation for this move, I can see same is done in multiple other patches? Header file is still included by .c file, what is the benefit of moving from header to .c f

[PATCH v3 12/27] net/nfp: refact the hwinfo module

Move the definition of data structure and macro into the implement file. Also remove the unneeded header file include statements. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfpcore/nfp_hwinfo.c | 84 +--- drivers/net/nfp/nfpcore/nfp_hwin