Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-10-07 Thread Stephen Hemminger
On Tue, 2 Apr 2024 09:19:23 -0700 Tyler Retzlaff wrote: > On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined refe

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-08 Thread Tyler Retzlaff
On Sat, Apr 06, 2024 at 07:30:38PM -0600, Ashish Sadanandan wrote: > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon wrote: > > > 02/04/2024 18:03, Ashish Sadanandan: > > > Hi everyone, > > > I've made the updates as suggested. Could someone please review the > > latest > > > patchset? Not sure if

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-08 Thread Bruce Richardson
On Mon, Apr 08, 2024 at 09:50:51AM +0100, Ferruh Yigit wrote: > On 4/7/2024 2:30 AM, Ashish Sadanandan wrote: > > > > > > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon > > wrote: > > > > 02/04/2024 18:03, Ashish Sadanandan: > > > Hi everyone, > > > I've

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-08 Thread Ferruh Yigit
On 4/7/2024 2:30 AM, Ashish Sadanandan wrote: > > > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon > wrote: > > 02/04/2024 18:03, Ashish Sadanandan: > > Hi everyone, > > I've made the updates as suggested. Could someone please review > the latest >

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-07 Thread Stephen Hemminger
On Sat, 6 Apr 2024 19:30:38 -0600 Ashish Sadanandan wrote: > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon wrote: > > > 02/04/2024 18:03, Ashish Sadanandan: > > > Hi everyone, > > > I've made the updates as suggested. Could someone please review the > > latest > > > patchset? Not sure if

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-06 Thread Ashish Sadanandan
On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon wrote: > 02/04/2024 18:03, Ashish Sadanandan: > > Hi everyone, > > I've made the updates as suggested. Could someone please review the > latest > > patchset? Not sure if I followed the new patchset instructions correctly, > > I've always had trouble

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-03 Thread Thomas Monjalon
02/04/2024 18:03, Ashish Sadanandan: > Hi everyone, > I've made the updates as suggested. Could someone please review the latest > patchset? Not sure if I followed the new patchset instructions correctly, > I've always had trouble with that part. I remember we were discussing about aligning all fi

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Tyler Retzlaff
On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Also updated the coding style cont

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Bruce Richardson
On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Also updated the coding style cont

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Ashish Sadanandan
Hi everyone, I've made the updates as suggested. Could someone please review the latest patchset? Not sure if I followed the new patchset instructions correctly, I've always had trouble with that part. Thanks, Ashish. On Sun, Mar 17, 2024 at 8:44 PM Ashish Sadanandan < ashish.sadanan...@gmail.com

[PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-17 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Also updated the coding style contribution guideline with a new "Language Linkage" section stating `extern "C"`