Re: [PATCH v3 02/27] net/nfp: unify the indent coding style

2023-09-17 Thread Stephen Hemminger
On Mon, 18 Sep 2023 01:25:28 + Chaoyong He wrote: > > From: Ferruh Yigit > > Sent: Friday, September 15, 2023 9:41 PM > > To: Chaoyong He ; dev@dpdk.org > > Cc: oss-drivers ; Niklas Soderlund > > > > Subject: Re: [PATCH v3 02/27] net/nfp: unify the inden

RE: [PATCH v3 02/27] net/nfp: unify the indent coding style

2023-09-17 Thread Chaoyong He
> From: Ferruh Yigit > Sent: Friday, September 15, 2023 9:41 PM > To: Chaoyong He ; dev@dpdk.org > Cc: oss-drivers ; Niklas Soderlund > > Subject: Re: [PATCH v3 02/27] net/nfp: unify the indent coding style > > On 9/15/2023 10:15 AM, Chaoyong He wrote: > > Eac

Re: [PATCH v3 02/27] net/nfp: unify the indent coding style

2023-09-15 Thread Ferruh Yigit
On 9/15/2023 10:15 AM, Chaoyong He wrote: > Each parameter of function should occupy one line, and indent two TAB > character. > No objection to it, but "Each parameter of function should occupy one line" is NOT coming from DPDK coding convention, right? If this is for driver code consistancey, th

[PATCH v3 02/27] net/nfp: unify the indent coding style

2023-09-15 Thread Chaoyong He
Each parameter of function should occupy one line, and indent two TAB character. All the statement which span multi line should indent two TAB character. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfpcore/nfp_cpp.h | 80 +- drivers/net/nfp/nfp