Re: [PATCH v3] dmadev: fix structure alignment

2024-06-27 Thread Thomas Monjalon
20/03/2024 10:31, fengchengwen: > Reviewed-by: Chengwen Feng > > On 2024/3/20 15:23, Wenwu Ma wrote: > > The structure rte_dma_dev needs to be aligned to the cache line, but > > the return value of malloc may not be aligned to the cache line. When > > we use memset to clear the rte_dma_dev object

Re: [PATCH v3] dmadev: fix structure alignment

2024-03-21 Thread Tyler Retzlaff
On Thu, Mar 21, 2024 at 11:06:34AM +0100, Thomas Monjalon wrote: > 21/03/2024 10:18, Ma, WenwuX: > > From: Thomas Monjalon > > > 21/03/2024 02:25, Ma, WenwuX: > > > > From: Thomas Monjalon > > > > > 20/03/2024 08:23, Wenwu Ma: > > > > > > The structure rte_dma_dev needs to be aligned to the cache

Re: [PATCH v3] dmadev: fix structure alignment

2024-03-21 Thread Thomas Monjalon
21/03/2024 10:18, Ma, WenwuX: > From: Thomas Monjalon > > 21/03/2024 02:25, Ma, WenwuX: > > > From: Thomas Monjalon > > > > 20/03/2024 08:23, Wenwu Ma: > > > > > The structure rte_dma_dev needs to be aligned to the cache line, > > > > > but the return value of malloc may not be aligned to the cac

RE: [PATCH v3] dmadev: fix structure alignment

2024-03-21 Thread Ma, WenwuX
Hi, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 21, 2024 4:31 PM > To: fengcheng...@huawei.com; Ma, WenwuX > Cc: dev@dpdk.org; Jiale, SongX ; sta...@dpdk.org > Subject: Re: [PATCH v3] dmadev: fix structure alignment > > 21/0

RE: [PATCH v3] dmadev: fix structure alignment

2024-03-21 Thread Ma, WenwuX
Hi, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 21, 2024 4:31 PM > To: fengcheng...@huawei.com; Ma, WenwuX > Cc: dev@dpdk.org; Jiale, SongX ; sta...@dpdk.org > Subject: Re: [PATCH v3] dmadev: fix structure alignment > > 21/0

Re: [PATCH v3] dmadev: fix structure alignment

2024-03-21 Thread Thomas Monjalon
21/03/2024 02:25, Ma, WenwuX: > Hi, Thomas > > From: Thomas Monjalon > > 20/03/2024 08:23, Wenwu Ma: > > > The structure rte_dma_dev needs to be aligned to the cache line, but > > > the return value of malloc may not be aligned to the cache line. When > > > we use memset to clear the rte_dma_dev

RE: [PATCH v3] dmadev: fix structure alignment

2024-03-20 Thread Ma, WenwuX
Hi, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 20, 2024 7:37 PM > To: fengcheng...@huawei.com; Ma, WenwuX > Cc: dev@dpdk.org; Jiale, SongX ; sta...@dpdk.org > Subject: Re: [PATCH v3] dmadev: fix structure alignment > > 20

Re: [PATCH v3] dmadev: fix structure alignment

2024-03-20 Thread Thomas Monjalon
20/03/2024 08:23, Wenwu Ma: > The structure rte_dma_dev needs to be aligned to the cache line, but > the return value of malloc may not be aligned to the cache line. When > we use memset to clear the rte_dma_dev object, it may cause a segmentation > fault in clang-x86-platform. > > This is because

Re: [PATCH v3] dmadev: fix structure alignment

2024-03-20 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2024/3/20 15:23, Wenwu Ma wrote: > The structure rte_dma_dev needs to be aligned to the cache line, but > the return value of malloc may not be aligned to the cache line. When > we use memset to clear the rte_dma_dev object, it may cause a segmentation > fault in cla

[PATCH v3] dmadev: fix structure alignment

2024-03-20 Thread Wenwu Ma
The structure rte_dma_dev needs to be aligned to the cache line, but the return value of malloc may not be aligned to the cache line. When we use memset to clear the rte_dma_dev object, it may cause a segmentation fault in clang-x86-platform. This is because clang uses the "vmovaps" assembly instr