Re: [PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

2025-02-05 Thread Andre Muezerie
On Wed, Feb 05, 2025 at 05:35:26PM +0100, David Marchand wrote: > Hello André, > > On Tue, Feb 4, 2025 at 9:57 PM Andre Muezerie > wrote: > > @@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun > > assign_fun, flip_fun flip_fun, size > > rand_bitset(bitset, size); > > > >

Re: [PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

2025-02-05 Thread Stephen Hemminger
On Tue, 4 Feb 2025 12:57:09 -0800 Andre Muezerie wrote: > +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 11) > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Warray-bounds" > +#endif > > + /* gcc is giving false positives here when code is optimized */ >

Re: [PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

2025-02-05 Thread David Marchand
Hello André, On Tue, Feb 4, 2025 at 9:57 PM Andre Muezerie wrote: > @@ -168,10 +169,20 @@ test_flip_size(test_fun test_fun, assign_fun > assign_fun, flip_fun flip_fun, size > rand_bitset(bitset, size); > > for (i = 0; i < size; i++) { > - RTE_BITSET_DECLARE(referenc

[PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

2025-02-04 Thread Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695