Re: [PATCH v2 5/6] dts: add conditional behavior for test suite

2024-11-18 Thread Luca Vizzarro
The issue you mention should be resolved now with the Pydantic changes. Do we still have reason to make this change? I guess we could make the test suites in the config file optional, in which case you can just add a default to the field and remove the constraint.

Re: [PATCH v2 5/6] dts: add conditional behavior for test suite

2024-11-06 Thread Dean Marx
On Fri, Jul 5, 2024 at 1:20 PM Nicholas Pratte wrote: > There is some odd functionality/behavior in how the --test-suite > parameters interacts in conjunction with the 'test_suites' attribute in > the config file. If a user leaves an empty list underneath > 'test_suites,' or if they negate the at

Re: [PATCH v2 5/6] dts: add conditional behavior for test suite

2024-09-10 Thread Juraj Linkeš
On 5. 7. 2024 19:13, Nicholas Pratte wrote: There is some odd functionality/behavior in how the --test-suite parameters interacts in conjunction with the 'test_suites' attribute in the config file. If a user leaves an empty list underneath 'test_suites,' or if they negate the attribute entirel

Re: [PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-16 Thread Jeremy Spewock
I think it makes sense to allow users to not specify any test suites in the config file if they specify them through other means, so I like this change. On Fri, Jul 5, 2024 at 1:20 PM Nicholas Pratte wrote: > > There is some odd functionality/behavior in how the --test-suite > parameters interact

[PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-05 Thread Nicholas Pratte
There is some odd functionality/behavior in how the --test-suite parameters interacts in conjunction with the 'test_suites' attribute in the config file. If a user leaves an empty list underneath 'test_suites,' or if they negate the attribute entirely, even if said user adds test suites via the --t

[PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-05 Thread Nicholas Pratte
There is some odd functionality/behavior in how the --test-suite parameters interacts in conjunction with the 'test_suites' attribute in the config file. If a user leaves an empty list underneath 'test_suites,' or if they negate the attribute entirely, even if said user adds test suites via the --t