Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
On 9. 9. 2024 16:20, Jeremy Spewock wrote: On Fri, Sep 6, 2024 at 12:46 PM Luca Vizzarro wrote: On 23/08/2024 13:16, Juraj Linkeš wrote: As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the veri

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Jeremy Spewock
On Fri, Sep 6, 2024 at 12:46 PM Luca Vizzarro wrote: > > On 23/08/2024 13:16, Juraj Linkeš wrote: > > As Jeremy mentioned, adding the verify argument may be worthwhile, but > > maybe only if we actually identify a usecase where we wouldn't want to > > do the verification. > > Yeah, as I pointed ou

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
On 6. 9. 2024 18:46, Luca Vizzarro wrote: On 23/08/2024 13:16, Juraj Linkeš wrote: As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the verification. Yeah, as I pointed out, it feels unlikely to

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-06 Thread Luca Vizzarro
On 23/08/2024 13:16, Juraj Linkeš wrote: As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the verification. Yeah, as I pointed out, it feels unlikely to pretend that they are started (or stopped).

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-06 Thread Luca Vizzarro
On 09/08/2024 16:13, Jeremy Spewock wrote: I tried to address this very same problem in the scatter expansion patch series but, admittedly, I like your approach better. There is one thing that Juraj and I discussed on that thread however that is probably worth noting here regarding verification o

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-08-23 Thread Juraj Linkeš
As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the verification. I also have two other points: 1. Do we want a decorator that does both - starting and stopping? Is the idea to have all methods tha

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-08-09 Thread Jeremy Spewock
I tried to address this very same problem in the scatter expansion patch series but, admittedly, I like your approach better. There is one thing that Juraj and I discussed on that thread however that is probably worth noting here regarding verification of the stopping and starting ports. The main i

[PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-08-06 Thread Luca Vizzarro
Add testpmd commands to start and stop all the ports, so that they can be configured. Because there is a distinction of commands that require the ports to be stopped and started, also add decorators for commands that require a specific state, removing this logic from the test writer's duty. Signed