Re: [PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-09-06 Thread Hunt, David
Hi Tadhg, On 13/07/2022 15:07, Tadhg Kearney wrote: Add option for setting uncore frequency min/max/index, through uncore api. This will be set for each package and die on the SKU. On exit, uncore frequency will be reverted back to previous frequency. Signed-off-by: Tadhg Kearney --- .../sam

RE: [PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-07-21 Thread Pattan, Reshma
> -Original Message- > From: Kearney, Tadhg > +static int > +parse_uncore_index(const char *choice) > +{ > + if (frequency_index > freq_array_len) { Should this be compared against freq_array_len-1 ?. Ex: If total 10 frequencies the index can be only 0-9. Thanks, Reshma

RE: [PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-07-21 Thread Pattan, Reshma
> -Original Message- > From: Kearney, Tadhg > +* -i (frequency index): optional, sets uncore frequency to frequency index > value, by setting min and max values to be the same. > + This is not optional argument. Need to remove optional in the help text of the parameter. > +``-i

[PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-07-13 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore api. This will be set for each package and die on the SKU. On exit, uncore frequency will be reverted back to previous frequency. Signed-off-by: Tadhg Kearney --- .../sample_app_ug/l3_forward_power_man.rst| 28 +++ exampl