Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2024-02-16 Thread Tyler Retzlaff
On Fri, Feb 16, 2024 at 09:02:29AM +0100, David Marchand wrote: > On Fri, Feb 16, 2024 at 1:33 AM Tyler Retzlaff > wrote: > > > > ping > > > > i'd like to see this change go in asap since it is pre-requisite to > > turning on -Wvla which explicitly caught use of non-constant expressions > > in the

Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2024-02-16 Thread David Marchand
On Fri, Feb 16, 2024 at 1:33 AM Tyler Retzlaff wrote: > > ping > > i'd like to see this change go in asap since it is pre-requisite to > turning on -Wvla which explicitly caught use of non-constant expressions > in the RTE_BUILD_BUG_ON() hiding bugs. That was the last thing I applied yesterday. I

RE: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2024-02-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 16 February 2024 01.34 > > ping > > i'd like to see this change go in asap since it is pre-requisite to > turning on -Wvla which explicitly caught use of non-constant > expressions > in the RTE_BUILD_BUG_ON() hiding bugs

Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2024-02-15 Thread Tyler Retzlaff
ping i'd like to see this change go in asap since it is pre-requisite to turning on -Wvla which explicitly caught use of non-constant expressions in the RTE_BUILD_BUG_ON() hiding bugs. thanks! On Mon, Nov 13, 2023 at 09:06:05AM -0800, Stephen Hemminger wrote: > Both Gcc, clang and MSVC have bett

Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 05:12:48PM +, Bruce Richardson wrote: > On Mon, Nov 13, 2023 at 09:06:05AM -0800, Stephen Hemminger wrote: > > Both Gcc, clang and MSVC have better way to do compile time > > assertions rather than using out of bounds array access. > > The old method would fail if -Wvla

Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2023-11-13 Thread Bruce Richardson
On Mon, Nov 13, 2023 at 09:06:05AM -0800, Stephen Hemminger wrote: > Both Gcc, clang and MSVC have better way to do compile time > assertions rather than using out of bounds array access. > The old method would fail if -Wvla is enabled because compiler > can't determine size in that code. Also, th

[PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2023-11-13 Thread Stephen Hemminger
Both Gcc, clang and MSVC have better way to do compile time assertions rather than using out of bounds array access. The old method would fail if -Wvla is enabled because compiler can't determine size in that code. Also, the use of new _Static_assert will catch broken code that is passing non-cons