Re: [PATCH v2 2/3] baseband/acc: refactor queue status update

2024-09-10 Thread Maxime Coquelin
On 8/13/24 01:42, Nicolas Chautru wrote: Introducing common function for queue stats update within the acc PMDs. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 18 drivers/baseband/acc/rte_acc100_pmd.c | 45 ++-- drivers/baseband/acc/r

Re: [PATCH v2 2/3] baseband/acc: refactor queue status update

2024-08-13 Thread Mattia Milani
My bad, please ignore the first comment, I've confused the - and + on the left side. sorry for the misunderstanding. For the second I still think would make more sense to reset the statistics at when a queue is started rather than stopped. On 13/08/2024 09:24, Mattia Milani wrote: Dear all,

Re: [PATCH v2 2/3] baseband/acc: refactor queue status update

2024-08-13 Thread Mattia Milani
Dear all, I'm a DPDK newbie, but I hope anyway you are gonna consider my comments or help me to understand the code a little bit better. 1) Aren't you updating the variable two times? for example, in 'acc100_enqueue_enc_cb',     you update both 'enqueued_count' and 'enqueue_err_count' and then

[PATCH v2 2/3] baseband/acc: refactor queue status update

2024-08-12 Thread Nicolas Chautru
Introducing common function for queue stats update within the acc PMDs. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 18 drivers/baseband/acc/rte_acc100_pmd.c | 45 ++-- drivers/baseband/acc/rte_vrb_pmd.c| 61 +--