Re: [PATCH v2 1/8] net/ice: fix check for outer UDP checksum offload

On Fri, Apr 05, 2024 at 04:45:55PM +0200, David Marchand wrote: > ICE_TX_CTX_EIPT_NONE == 0. > There is a good chance that !(anything & 0) is true :-). > > While removing this noop check is doable, let's check that the > descriptor does contain a outer ip type. > > Fixes: 2ed011776334 ("net/ice:

[PATCH v2 1/8] net/ice: fix check for outer UDP checksum offload

ICE_TX_CTX_EIPT_NONE == 0. There is a good chance that !(anything & 0) is true :-). While removing this noop check is doable, let's check that the descriptor does contain a outer ip type. Fixes: 2ed011776334 ("net/ice: fix outer UDP Tx checksum offload") Signed-off-by: David Marchand --- Change