Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-11 Thread Jie Hai
On 2023/9/9 4:58, Stephen Hemminger wrote: On Fri, 8 Sep 2023 17:28:08 +0800 Jie Hai wrote: Hi, Stephen Hemminger On 2023/9/6 23:10, Stephen Hemminger wrote: On Sat, 26 Aug 2023 15:46:03 +0800 Jie Hai wrote: Currently, rte_eth_rss_conf supports configuring and querying rss hash functio

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-11 Thread Ajit Khaparde
On Mon, Sep 11, 2023 at 3:09 AM Thomas Monjalon wrote: > > 09/09/2023 02:01, Ajit Khaparde: > > On Fri, Sep 8, 2023 at 1:44 AM Jie Hai wrote: > > > > > > Hi, Thomas > > > Thanks for your review. > > > > > > On 2023/9/4 15:45, Thomas Monjalon wrote: > > > > 04/09/2023 09:10, Jie Hai: > > > >> On 2

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-11 Thread Thomas Monjalon
09/09/2023 02:01, Ajit Khaparde: > On Fri, Sep 8, 2023 at 1:44 AM Jie Hai wrote: > > > > Hi, Thomas > > Thanks for your review. > > > > On 2023/9/4 15:45, Thomas Monjalon wrote: > > > 04/09/2023 09:10, Jie Hai: > > >> On 2023/8/30 19:46, Thomas Monjalon wrote: > > >>> 26/08/2023 09:46, Jie Hai: >

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-08 Thread Ajit Khaparde
On Fri, Sep 8, 2023 at 1:44 AM Jie Hai wrote: > > Hi, Thomas > Thanks for your review. > > On 2023/9/4 15:45, Thomas Monjalon wrote: > > 04/09/2023 09:10, Jie Hai: > >> On 2023/8/30 19:46, Thomas Monjalon wrote: > >>> 26/08/2023 09:46, Jie Hai: > > >> + * The *func* field of the *rss_conf* struc

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-08 Thread Stephen Hemminger
On Fri, 8 Sep 2023 17:28:08 +0800 Jie Hai wrote: > Hi, Stephen Hemminger > > On 2023/9/6 23:10, Stephen Hemminger wrote: > > On Sat, 26 Aug 2023 15:46:03 +0800 > > Jie Hai wrote: > > > >> Currently, rte_eth_rss_conf supports configuring and querying > >> rss hash functions, rss key and it's

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-08 Thread Jie Hai
Hi, Stephen Hemminger On 2023/9/6 23:10, Stephen Hemminger wrote: On Sat, 26 Aug 2023 15:46:03 +0800 Jie Hai wrote: Currently, rte_eth_rss_conf supports configuring and querying rss hash functions, rss key and it's length, but not rss hash algorithm. The structure ``rte_eth_rss_conf`` is ext

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-08 Thread Jie Hai
Hi, Thomas Thanks for your review. On 2023/9/4 15:45, Thomas Monjalon wrote: 04/09/2023 09:10, Jie Hai: On 2023/8/30 19:46, Thomas Monjalon wrote: 26/08/2023 09:46, Jie Hai: >> + * The *func* field of the *rss_conf* structure indicates the hash algorithm + * applied by the RSS hashing. Pa

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-05 Thread Ajit Khaparde
> >> How the algorithms support combinations in rss_hf? > > I will spend a little more time on this tomorrow. > > Can you update testpmd also to display the info as a part of show rss. > > > Hi, Ajit Khaparde, > > Displaying RSS hash algorithms with testpmd is in progress. > However, there are some

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-04 Thread Thomas Monjalon
04/09/2023 09:10, Jie Hai: > On 2023/8/30 19:46, Thomas Monjalon wrote: > > 26/08/2023 09:46, Jie Hai: >> + * The *func* field of the *rss_conf* structure indicates the hash >> algorithm > >> + * applied by the RSS hashing. Passing RTE_ETH_HASH_FUNCTION_DEFAULT > >> allows > >> + * the PMD to u

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-04 Thread Jie Hai
Hi, Thomas Thanks for your review. On 2023/8/30 19:46, Thomas Monjalon wrote: Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: Currently, rte_eth_rss_conf supports configuring and querying rss hash functions, rss key and it's length, but not rss hash algorithm. The st

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-09-03 Thread Jie Hai
On 2023/8/31 8:10, Ajit Khaparde wrote: On Wed, Aug 30, 2023 at 4:46 AM Thomas Monjalon wrote: Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: Currently, rte_eth_rss_conf supports configuring and querying rss hash functions, rss key and it's length, but not rss hash

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-08-31 Thread Jie Hai
On 2023/8/31 8:10, Ajit Khaparde wrote: On Wed, Aug 30, 2023 at 4:46 AM Thomas Monjalon wrote: Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: Currently, rte_eth_rss_conf supports configuring and querying rss hash functions, rss key and it's length, but not rss hash

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-08-30 Thread Ajit Khaparde
On Wed, Aug 30, 2023 at 4:46 AM Thomas Monjalon wrote: > > Hello, > > Thanks for bringing a new capability. > > 26/08/2023 09:46, Jie Hai: > > Currently, rte_eth_rss_conf supports configuring and querying > > rss hash functions, rss key and it's length, but not rss hash > > algorithm. > > > > The

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-08-30 Thread Thomas Monjalon
Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: > Currently, rte_eth_rss_conf supports configuring and querying > rss hash functions, rss key and it's length, but not rss hash > algorithm. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "func".

[PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-08-26 Thread Jie Hai
Currently, rte_eth_rss_conf supports configuring and querying rss hash functions, rss key and it's length, but not rss hash algorithm. The structure ``rte_eth_rss_conf`` is extended by adding a new field "func". This represents the RSS algorithms to apply. The following API is affected: -