RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Dumitrescu, Cristian
> > -/* rte_sched defines */ > > -#undef RTE_SCHED_CMAN > > So what is the purpose of the code under RTE_SCHED_CMAN #ifdef? > Is it a dead code? Should it be enabled with a hidden option? > We want to keep congestion management enabled through CFLAGS for now, as we have a bit more homework to d

RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Dumitrescu, Cristian
> > +/* KNI defines */ > > +#define RTE_KNI_PREEMPT_DEFAULT 1 > > The KNI addition is unrelated. > > Why these KNI lines, hopefully it is not intentional and it will get removed in the next version?

RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH v2 1/4] sched: Cleanup qos scheduler defi

Re: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Thomas Monjalon
18/02/2022 10:36, Megha Ajmera: > Cleanup of sched config options those are by-default not defined. > > Signed-off-by: Megha Ajmera > Acked-by: Cristian Dumitrescu > --- > config/rte_config.h| 8 ++-- > doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- > lib/sched/

[PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Megha Ajmera
Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h| 8 ++-- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 3 fil