RE: [PATCH v2 1/3] net: add thread-safe crc api

2025-02-06 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 9, 2024 3:03 AM > To: Kusztal, ArkadiuszX ; Marchand, David > > Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian > > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On 10/8/202

RE: [PATCH v2 1/3] net: add thread-safe crc api

2025-02-06 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Stephen Hemminger > Sent: Monday, December 2, 2024 11:36 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; ferruh.yi...@amd.com; Ji, Kai ; Dooley, > Brian > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On Tue,

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-12-02 Thread Stephen Hemminger
On Tue, 1 Oct 2024 19:11:48 +0100 Arkadiusz Kusztal wrote: > The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. Couldn't the old API be made threadsafe with TLS? > This API is also safe to use across multiple processes, > yet with

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-09 Thread Ferruh Yigit
Yigit >>>> Sent: Tuesday, October 8, 2024 5:43 AM >>>> To: Kusztal, ArkadiuszX ; Marchand, >>>> David >>>> Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian >>>> >>>> Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api >>&g

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-09 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 9, 2024 3:03 AM > To: Kusztal, ArkadiuszX ; Marchand, David > > Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian > > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On 10/8/202

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-08 Thread Ferruh Yigit
gt; Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian >> >> Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api >> >> On 10/1/2024 7:11 PM, Arkadiusz Kusztal wrote: >>> The current net CRC API is not thread-safe, this patch solves this by >>> adding another, thr

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-08 Thread Kusztal, ArkadiuszX
Hi Ferruh, Thanks for the review, comments inline, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 8, 2024 5:43 AM > To: Kusztal, ArkadiuszX ; Marchand, David > > Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian > > Subject: Re: [PATCH v2 1/3] net:

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-07 Thread Ferruh Yigit
On 10/1/2024 7:11 PM, Arkadiusz Kusztal wrote: > The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. > This API is also safe to use across multiple processes, > yet with limitations on max-simd-bitwidth, which will be checked only by >

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-02 Thread Kusztal, ArkadiuszX
> -Original Message- > From: David Marchand > Sent: Wednesday, October 2, 2024 11:02 AM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; ferruh.yi...@amd.com; Ji, Kai ; Dooley, > Brian > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On Wed, Oct

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-02 Thread David Marchand
On Wed, Oct 2, 2024 at 10:42 AM Kusztal, ArkadiuszX wrote: > > Exporting internals but not using them out of the library makes no sense. > > > So there must have been a misunderstanding on my part, the initial idea was > to prevent the user from calling these functions. net_crc.h is an internal

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-02 Thread Kusztal, ArkadiuszX
> -Original Message- > From: David Marchand > Sent: Wednesday, October 2, 2024 9:42 AM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; ferruh.yi...@amd.com; Ji, Kai ; Dooley, > Brian > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On Tue, Oct 1

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-02 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 1, 2024 11:44 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; ferruh.yi...@amd.com; Ji, Kai ; Dooley, > Brian > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On Tue,

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-02 Thread David Marchand
On Tue, Oct 1, 2024 at 9:27 PM Arkadiusz Kusztal wrote: > > The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. > This API is also safe to use across multiple processes, > yet with limitations on max-simd-bitwidth, which will be checke

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2024 19:11:48 +0100 Arkadiusz Kusztal wrote: > diff --git a/lib/net/version.map b/lib/net/version.map > index bec4ce23ea..47daf1464a 100644 > --- a/lib/net/version.map > +++ b/lib/net/version.map > @@ -4,11 +4,25 @@ DPDK_25 { > rte_eth_random_addr; > rte_ether_format_ad

[PATCH v2 1/3] net: add thread-safe crc api

2024-10-01 Thread Arkadiusz Kusztal
The current net CRC API is not thread-safe, this patch solves this by adding another, thread-safe API functions. This API is also safe to use across multiple processes, yet with limitations on max-simd-bitwidth, which will be checked only by the process that created the CRC context; all other proce