Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-09 Thread Tyler Retzlaff
On Thu, Dec 08, 2022 at 05:09:32PM -0800, Stephen Hemminger wrote: > On Tue, 6 Dec 2022 09:28:24 -0800 > Tyler Retzlaff wrote: > > > + /* Wait for the control thread to initialize successfully */ > > + while ((ctrl_thread_status = > > + __atomic_load_n(¶ms->ctrl_thread_stat

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-08 Thread Stephen Hemminger
On Tue, 6 Dec 2022 09:28:24 -0800 Tyler Retzlaff wrote: > + /* Wait for the control thread to initialize successfully */ > + while ((ctrl_thread_status = > + __atomic_load_n(¶ms->ctrl_thread_status, > + __ATOMIC_ACQUIRE)) == CTRL_THREAD_LAUNCHING)

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-08 Thread Tyler Retzlaff
On Thu, Dec 08, 2022 at 10:59:13PM +0100, Mattias Rönnblom wrote: > On 2022-12-07 17:38, Tyler Retzlaff wrote: > > > >> > >>>+ } u; > >>> void *arg; > >>> int ret; > >> > >>Why is 'ret' needed? (This question is unrelated to your patch.) > > > >i'm not the original author so difficult to answe

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-08 Thread Mattias Rönnblom
On 2022-12-07 17:38, Tyler Retzlaff wrote: On Wed, Dec 07, 2022 at 10:13:39AM +0100, Mattias Rönnblom wrote: On 2022-12-06 18:28, Tyler Retzlaff wrote: Add rte_control_thread_create API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPD

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-07 Thread Tyler Retzlaff
just following up. On Wed, Dec 07, 2022 at 08:38:39AM -0800, Tyler Retzlaff wrote: > On Wed, Dec 07, 2022 at 10:13:39AM +0100, Mattias Rönnblom wrote: > > > > To be consistent with function naming scheme, where "ctrl" is the > > old API, and "control" the new, you could call the start functions >

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-07 Thread Tyler Retzlaff
On Wed, Dec 07, 2022 at 10:13:39AM +0100, Mattias Rönnblom wrote: > On 2022-12-06 18:28, Tyler Retzlaff wrote: > >Add rte_control_thread_create API as a replacement for > >rte_ctrl_thread_create to allow deprecation of the use of platform > >specific types in DPDK public API. > > > >Signed-off-by:

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-07 Thread Mattias Rönnblom
On 2022-12-06 18:28, Tyler Retzlaff wrote: Add rte_control_thread_create API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 93 +++

[PATCH v2 1/3] eal: add rte control thread create API

2022-12-06 Thread Tyler Retzlaff
Add rte_control_thread_create API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 93 ++ lib/eal/include/rte_threa