Hi Stephen,
Thanks for the review, I'll address your comments in v3
On 08/10/2024 19:28, Stephen Hemminger wrote:
On Tue, 8 Oct 2024 17:55:23 +
Vladimir Medvedkin wrote:
+ if ((tbl8_idx == -ENOSPC) && dp->dq != NULL) {
Better to either drop the parenthesis here, or put it on both
-
From: Stephen Hemminger
Sent: Tuesday, October 8, 2024 1:18 PM
To: Vladimir Medvedkin
Cc: dev@dpdk.org; rja...@redhat.com; Ruifeng Wang ;
Honnappa Nagarahalli ; david.march...@redhat.com
Subject: Re: [PATCH v2 1/2] fib: implement RCU rule reclamation
On Tue, 8 Oct 2024 17:55:23 +
On Tue, 8 Oct 2024 17:55:23 +
Vladimir Medvedkin wrote:
> + if ((tbl8_idx == -ENOSPC) && dp->dq != NULL) {
Better to either drop the parenthesis here, or put it on both conditions.
> + /* If there are no tbl8 groups try to reclaim one. */
> + if (rte_rcu_qsbr_dq_
On Tue, 8 Oct 2024 17:55:23 +
Vladimir Medvedkin wrote:
> @@ -569,7 +600,60 @@ dir24_8_free(void *p)
> {
> struct dir24_8_tbl *dp = (struct dir24_8_tbl *)p;
>
> + if (dp->dq != NULL)
> + rte_rcu_qsbr_dq_delete(dp->dq);
> +
Side note:
rte_rcu_qsbr_dq_delete should be
Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the
readers might be using the tbl8 group entries. The freed tbl8 group can
be reallocated quickly. As a result, lookup may be performed incorrectly.
To address that, RCU QSBR is integrated for safe tbl8 group reclamation.
Sign
5 matches
Mail list logo
