Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-11-19 Thread Bruce Richardson
On Fri, Oct 25, 2024 at 11:26:14PM +0300, Dmitry Kozlyuk wrote: > It was impossible to include mapped contigmem buffers in core dump. > Add hw.contigmem.coredump_enable tunable to control the inclusion. > > Mappings backed by OBJ_FICTITIOUS are excluded from core dump. > While contigmem is a devic

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-11-19 Thread Thomas Monjalon
19/11/2024 19:27, Dmitry Kozlyuk: > 2024-11-19 15:48 (UTC+), Bruce Richardson: > > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > > > Is the extra control necessary, i.e., why not just always do this and > > > > let > > >

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-11-19 Thread Dmitry Kozlyuk
2024-11-19 15:48 (UTC+), Bruce Richardson: > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > > Is the extra control necessary, i.e., why not just always do this and let > > > the EAL option control whether the pages get dumped

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-11-19 Thread Bruce Richardson
On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > Is the extra control necessary, i.e., why not just always do this and let > > the EAL option control whether the pages get dumped? > > I've been evaluating your suggestion and see no do

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-10-28 Thread Lewis Donzis
It seems unlikely that there are other users of contigmem on FreeBSD, especially since it's not necessary for other applications. On FreeBSD, use of large and huge pages is automatic; you just call mmap() with a large size and it automatically tries to use the largest physical pages possible.

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-10-28 Thread Dmitry Kozlyuk
2024-10-26 06:43 (UTC-0500), Lewis Donzis: > Is the extra control necessary, i.e., why not just always do this and let > the EAL option control whether the pages get dumped? I've been evaluating your suggestion and see no downsides, except contigmem default behavior change, but does it have non-DP

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-10-26 Thread Lewis Donzis
Is the extra control necessary, i.e., why not just always do this and let the EAL option control whether the pages get dumped? - On Oct 25, 2024, at 3:26 PM, Dmitry Kozlyuk dmitry.kozl...@gmail.com wrote: > It was impossible to include mapped contigmem buffers in core dump. > Add hw.contigm

[PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-10-25 Thread Dmitry Kozlyuk
It was impossible to include mapped contigmem buffers in core dump. Add hw.contigmem.coredump_enable tunable to control the inclusion. Mappings backed by OBJ_FICTITIOUS are excluded from core dump. While contigmem is a device and its OBJT_DEVICE mappings get this flag, they are actually backed by