Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 2:56 AM, Stephen Hemminger wrote: > On Fri, 1 Nov 2024 01:22:47 + > Ferruh Yigit wrote: > >> Hi Jiawen, >> >> Above are generic checks, we may add this function to ethdev driver >> header (ethdev_driver.h) so that any PMD can use it, what do you think? > > This is in the fastpat

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Stephen Hemminger
On Fri, 1 Nov 2024 01:22:47 + Ferruh Yigit wrote: > Hi Jiawen, > > Above are generic checks, we may add this function to ethdev driver > header (ethdev_driver.h) so that any PMD can use it, what do you think? This is in the fastpath, and additional checks should not be added there. Or at le

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Ferruh Yigit
On 11/1/2024 1:52 AM, Jiawen Wu wrote: > On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote: >> On 10/28/2024 2:31 AM, Jiawen Wu wrote: >>> Add checking of the Tx packet length to avoid TDM fatal error as far as >>> possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, >>> and drop

RE: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Jiawen Wu
On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote: > On 10/28/2024 2:31 AM, Jiawen Wu wrote: > > Add checking of the Tx packet length to avoid TDM fatal error as far as > > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, > > and drop it directly in featured Tx code path. > >

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Ferruh Yigit
On 10/28/2024 2:31 AM, Jiawen Wu wrote: > Add checking of the Tx packet length to avoid TDM fatal error as far as > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, > and drop it directly in featured Tx code path. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/tx

[PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-27 Thread Jiawen Wu
Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 33 + dr