Re: [PATCH v2 00/83] remove unnecessary null checks

2022-01-28 Thread Stephen Hemminger
On Fri, 28 Jan 2022 22:49:31 +0100 Thomas Monjalon wrote: > 24/01/2022 18:45, Stephen Hemminger: > > Stephen Hemminger (83): > > lib: update documentation of XXX_free() functions > > devtools/cocci: add script to fix unnecessary null checks > > I think it is good to have the first 2 patche

Re: [PATCH v2 00/83] remove unnecessary null checks

2022-01-28 Thread Thomas Monjalon
24/01/2022 18:45, Stephen Hemminger: > Stephen Hemminger (83): > lib: update documentation of XXX_free() functions > devtools/cocci: add script to fix unnecessary null checks I think it is good to have the first 2 patches separate, but the rest could go in a single third patch.

[PATCH v2 00/83] remove unnecessary null checks

2022-01-24 Thread Stephen Hemminger
While working on a new driver, noticed that some drivers always call free routines (correct) and others conditionally call free routines if not null (redundant check). The extra if(e != NULL) type check is unneeded and adds extra code. Better to have all the code consistent. The Linux kernel has