Re: [PATCH v2] vhost: fix madvise arguments alignment

2023-02-24 Thread Patrick Robb
UNH CI reported an ABI failure for this patch which did not report due to a bug on our end, so I'm manually reporting it now. I see Maxime you already predicted the issue though! *07:58:32* 1 function with some indirect sub-type change:*07:58:32* *07:58:32*[C] 'function int rte_vhost_get_mem_

Re: [PATCH v2] vhost: fix madvise arguments alignment

2023-02-23 Thread Mike Pattrick
On Thu, Feb 23, 2023 at 11:12 AM Maxime Coquelin wrote: > > Hi Mike, > > Thanks for looking into this issue. > > On 2/23/23 05:35, Mike Pattrick wrote: > > The arguments passed to madvise should be aligned to the alignment of > > the backing memory. Now we keep track of each regions alignment and

Re: [PATCH v2] vhost: fix madvise arguments alignment

2023-02-23 Thread Maxime Coquelin
Hi Mike, Thanks for looking into this issue. On 2/23/23 05:35, Mike Pattrick wrote: The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new me

[PATCH v2] vhost: fix madvise arguments alignment

2023-02-22 Thread Mike Pattrick
The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new member was added to rte_vhost_mem_region. A new function was added to easily translate memo