RE: [PATCH v2] sched: enable CMAN at runtime

Hi Cristian, Please find answers inline. > > Log: v2 change in rte_sched.h to avoid ABI breakage. Lessons learned, so I have fixed also positioning of this above. > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index > > ec74bee939..db14934832 100644 > > --- a/lib/sched/r

RE: [PATCH v2] sched: enable CMAN at runtime

+this time to dpdk.org , to test removal of automatic footer Hi Cristian, < snip > > > +++ b/lib/sched/rte_sched.h > > @@ -128,6 +128,8 @@ extern "C" { > > enum rte_sched_cman_mode { > > RTE_SCHED_CMAN_RED, /**< Random Early Detection (RED) */ > > RTE_SCHED_CMAN_PIE, /**< Proportional I

RE: [PATCH v2] sched: enable CMAN at runtime

Hi Cristian, > Can you please explain why you need to add the new > RTE_SCHED_CMAN_NONE value to this enumeration and what is the ABI > breakage that you are trying to avoid? > > The library expects the struct rte_sched_subport_params:: cman_params to > be NULL when the CMAN is disabled, why i

RE: [PATCH v2] sched: enable CMAN at runtime

Hi Marcin, Comments inline below. > -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime > &

RE: [PATCH v2] sched: enable CMAN at runtime

> -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime > > Added changes to enable CMAN

[PATCH v2] sched: enable CMAN at runtime

Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Log: v2 change in rte_sched.h to avoid ABI breakage. Signed-off-by: Marcin Danilewicz --- config/rte_config.h