Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-05-10 Thread Ferruh Yigit
On 4/20/2022 2:46 PM, Walter Heymans wrote: The 'max_rx_pktlen' value was previously read from hardware, which was set by the running firmware. This caused confusion due to different meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the maximum value that the NFP NIC can support. T

Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-05-04 Thread Walter Heymans
> overhead as according above calculation? Hi Ferruh, ​ The 'max_rx_pktlen' is hardcoded to the maximum packet length that the hardware can support. The 'hw->max_mtu' is read from hardware, but it is a variable value, depending on the firmware running on the card. The firmwar

Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-05-03 Thread Ferruh Yigit
On 4/20/2022 2:46 PM, Walter Heymans wrote: The 'max_rx_pktlen' value was previously read from hardware, which was set by the running firmware. This caused confusion due to different meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the maximum value that the NFP NIC can support. T

Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-04-27 Thread Niklas Söderlund
Hi Ferruh, On 2022-04-27 10:47:03 +0100, Ferruh Yigit wrote: > On 4/27/2022 9:37 AM, Niklas Söderlund wrote: > > Hello, > > > > I have a question about the Checks that ran on this patch in patchwork > > [1]. It appears the job ci/iol-x86_64-compile-testing, > > dpdk_mingw64_compile have failed on

Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-04-27 Thread Ferruh Yigit
On 4/27/2022 9:37 AM, Niklas Söderlund wrote: Hello, I have a question about the Checks that ran on this patch in patchwork [1]. It appears the job ci/iol-x86_64-compile-testing, dpdk_mingw64_compile have failed on a Windows Server 2019 build. But the logs from the job appears to be incomplete a

Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-04-27 Thread Niklas Söderlund
Hello, I have a question about the Checks that ran on this patch in patchwork [1]. It appears the job ci/iol-x86_64-compile-testing, dpdk_mingw64_compile have failed on a Windows Server 2019 build. But the logs from the job appears to be incomplete as it contains only 19 lines of output and st

[PATCH v2] net/nfp: update how MAX MTU is read

2022-04-20 Thread Walter Heymans
The 'max_rx_pktlen' value was previously read from hardware, which was set by the running firmware. This caused confusion due to different meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the maximum value that the NFP NIC can support. The 'max_mtu' value that is read from hardware,