RE: [PATCH v2] net/mlx5: fix lro update tcp header cksum error

2023-07-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: jiangheng (G) > Sent: Thursday, April 13, 2023 3:58 AM > To: Slava Ovsiienko ; dev@dpdk.org; Matan Azrad > > Subject: [PATCH v2] net/mlx5: fix lro update tcp header cksum error > > The variable csum is the sum of three 16 bits in

RE: [PATCH v2] net/mlx5: fix lro update tcp header cksum error

2023-07-14 Thread Slava Ovsiienko
lon > Sent: Thursday, July 13, 2023 3:16 PM > To: Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Cc: dev@dpdk.org; jiangheng (G) > Subject: Re: [PATCH v2] net/mlx5: fix lro update tcp header cksum error > > Any comment on this patch? > > 13/04/2023 02:57, ji

Re: [PATCH v2] net/mlx5: fix lro update tcp header cksum error

2023-07-13 Thread Thomas Monjalon
Any comment on this patch? 13/04/2023 02:57, jiangheng (G): > The variable csum is the sum of three 16 bits integers, the max value > is 0x2FFFD. The corner case of sum of 3 is 0x1 gives the wrong > result: 0x1 + 0x = 0x1, the upper 16 bits are not 0. > It must be folded again to ensur

[PATCH v2] net/mlx5: fix lro update tcp header cksum error

2023-04-12 Thread jiangheng (G)
The variable csum is the sum of three 16 bits integers, the max value is 0x2FFFD. The corner case of sum of 3 is 0x1 gives the wrong result: 0x1 + 0x = 0x1, the upper 16 bits are not 0. It must be folded again to ensure that the upper 16 bits are 0. Fixes: e4c2a16eb1de ("net/mlx5: hand