Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-03 Thread Thomas Monjalon
01/03/2024 19:00, Stephen Hemminger: > On Fri, 01 Mar 2024 16:20:56 +0100 > Thomas Monjalon wrote: > > > > > > > > > The use case is to get capabilities from the kernel driver via ethtool > > > > ioctl. > > > > > > > > > > Sure, as it is adding kernel ethtool conversion, DPDK driver will ge

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Stephen Hemminger
On Fri, 01 Mar 2024 16:20:56 +0100 Thomas Monjalon wrote: > > > > > > The use case is to get capabilities from the kernel driver via ethtool > > > ioctl. > > > > > > > Sure, as it is adding kernel ethtool conversion, DPDK driver will get > > link from kernel driver, thanks for clarification

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Ferruh Yigit
On 3/1/2024 3:20 PM, Thomas Monjalon wrote: > 01/03/2024 16:08, Ferruh Yigit: >> On 3/1/2024 1:37 PM, Thomas Monjalon wrote: >>> 01/03/2024 14:12, Ferruh Yigit: On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > Speed capabilities of a NIC may be discovered through its Linux > kernel drive

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Thomas Monjalon
01/03/2024 16:08, Ferruh Yigit: > On 3/1/2024 1:37 PM, Thomas Monjalon wrote: > > 01/03/2024 14:12, Ferruh Yigit: > >> On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > >>> Speed capabilities of a NIC may be discovered through its Linux > >>> kernel driver. It is especially useful for bifurcated drive

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Ferruh Yigit
On 3/1/2024 1:37 PM, Thomas Monjalon wrote: > 01/03/2024 14:12, Ferruh Yigit: >> On 2/29/2024 3:42 PM, Thomas Monjalon wrote: >>> Speed capabilities of a NIC may be discovered through its Linux >>> kernel driver. It is especially useful for bifurcated drivers, >>> so they don't have to duplicate th

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Thomas Monjalon
01/03/2024 14:12, Ferruh Yigit: > On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > > Speed capabilities of a NIC may be discovered through its Linux > > kernel driver. It is especially useful for bifurcated drivers, > > so they don't have to duplicate the same logic in the DPDK driver. > > > > Parsi

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Ferruh Yigit
On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > Speed capabilities of a NIC may be discovered through its Linux > kernel driver. It is especially useful for bifurcated drivers, > so they don't have to duplicate the same logic in the DPDK driver. > > Parsing ethtool speed capabilities is made easy t

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Thomas Monjalon
29/02/2024 18:38, Stephen Hemminger: > On Thu, 29 Feb 2024 17:58:13 +0100 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Thursday, 29 February 2024 17.45 > > > > > > On Thu, 29 Feb 2024 16:42:56 +0100 > > > Thomas Monjalon wrote: > > >

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-02-29 Thread Stephen Hemminger
On Thu, 29 Feb 2024 17:58:13 +0100 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, 29 February 2024 17.45 > > > > On Thu, 29 Feb 2024 16:42:56 +0100 > > Thomas Monjalon wrote: > > > > > +/* Link modes sorted with index as defined in et

RE: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-02-29 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 29 February 2024 17.45 > > On Thu, 29 Feb 2024 16:42:56 +0100 > Thomas Monjalon wrote: > > > +/* Link modes sorted with index as defined in ethtool. > > + * Values are speed in Mbps with LSB indicating duplex. > > +

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-02-29 Thread Stephen Hemminger
On Thu, 29 Feb 2024 16:42:56 +0100 Thomas Monjalon wrote: > +/* Link modes sorted with index as defined in ethtool. > + * Values are speed in Mbps with LSB indicating duplex. > + * > + * The ethtool bits definition should not change as it is a kernel API. > + * Using raw numbers directly avoids c

[PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-02-29 Thread Thomas Monjalon
Speed capabilities of a NIC may be discovered through its Linux kernel driver. It is especially useful for bifurcated drivers, so they don't have to duplicate the same logic in the DPDK driver. Parsing ethtool speed capabilities is made easy thanks to the functions added in ethdev for internal usa